Re: [PATCH 3/5] i2c: omap: handle all irqs befor unblockingomap_i2c_xfer_msg()

From: Felipe Balbi
Date: Fri Jun 07 2013 - 15:06:58 EST


On Fri, Jun 07, 2013 at 09:46:06PM +0300, Grygorii Strashko wrote:
> ARDY|NACK and ARDY|AL are set together in OMAP_I2C_STAT_REG, which will be

Have you seen that happen ever ? AL is Arbitration Lost, we never put
OMAP in a multi-master environment before.

ARDY | NACK I also find it a bit hard for those two to happen together
since ARDY will be set when you can change controller's register
*again*, mening that a transfer has completed.

Also, we need to follow what the programming model says. And, I don't
have docs with me right now, but IIRC it tells us to bail out if any of
the error conditions are met.


Attachment: signature.asc
Description: Digital signature