Re: [PATCH] mfd: vexpress: Make the driver optional for arm andarm64

From: Russell King - ARM Linux
Date: Mon Jun 10 2013 - 19:23:05 EST


On Mon, Jun 10, 2013 at 04:09:15PM +0100, Pawel Moll wrote:
> The driver can be used on either arm or arm64 platforms, but
> the latter doesn't have any platform-specific configuration
> options, so it must be possible to manually enable the driver.
>
> As the gpiolib is optional for arm64 arch, the gpio/led code
> must be compiled conditionally.
>
> Signed-off-by: Pawel Moll <pawel.moll@xxxxxxx>
> Acked-by: Catalin Marinas <catalin.marinas@xxxxxxx>
> ---
> drivers/mfd/Kconfig | 3 ++-
> drivers/mfd/vexpress-sysreg.c | 10 ++++++++--
> 2 files changed, 10 insertions(+), 3 deletions(-)
>
> Hi Samuel,
>
> Could you please queue this small change for 3.11?

Please use #ifdef rather than a single #if defined(). #if defined()
on its own is unnecessarily ugly.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/