Re: [PATCH] drivers/net/ethernet/3com: Drop EISA dependency fromVORTEX

From: Sergei Shtylyov
Date: Tue Jun 11 2013 - 14:10:00 EST


Hello.

On 11-06-2013 18:57, Markos Chandras wrote:

The Vortex driver depends on PCI with optional support for EISA.

This fixes build problems when EISA is selected but not PCI.

drivers/net/ethernet/3com/3c59x.c:1031:2: error: implicit declaration of
function 'pci_iomap' [-Werror=implicit-function-declaration]
drivers/net/ethernet/3com/3c59x.c:1044:3: error: implicit declaration of
function 'pci_iounmap' [-Werror=implicit-function-declaration]

Cc: David S. Miller <davem@xxxxxxxxxxxxx>
Cc: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
Cc: netdev@xxxxxxxxxxxxxxx
Signed-off-by: Markos Chandras <markos.chandras@xxxxxxxxxx>

The proper way to address this is probably add empty *static inline* function implementations for CONFIG_PCI=n case to the header file, same as was done with pci_{request|release}_regions() for this same file several years ago...

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/