Re: [RFC PATCH v3 2/2] drivers: mfd: vexpress: add Serial PowerController (SPC) support

From: Nicolas Pitre
Date: Thu Jun 13 2013 - 20:28:57 EST


On Thu, 13 Jun 2013, Olof Johansson wrote:

> > + u32 status = readl_relaxed(info->baseaddr + PWC_STATUS);
>
> Why readl_relaxed() here? Can't you use a normal readl()?

Unfortunately, on ARM readl_relaxed() _is_ the normal readl() because
the actual readl() may have side effects. See commit 79f64dbf68c8.


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/