Re: [PATCH v2 3/6] GPIO: xilinx: Use __raw_readl/__raw_writel IO functions

From: Linus Walleij
Date: Mon Jun 17 2013 - 01:46:56 EST

On Mon, Jun 3, 2013 at 2:31 PM, Michal Simek <michal.simek@xxxxxxxxxx> wrote:

> This driver can be used on Xilinx ARM Zynq platform
> where in_be32/out_be32 functions are not implemented.
> Use __raw_readl/__raw_writel functions which are
> implemented on Microblaze and PowerPC.
> For ARM readl/writel functions are used instead.
> The correct way how to implement this is to detect
> endians directly on IP. But for the gpio case
> without interrupt connected(it means without
> interrupt logic) there are just 2 registers
> data and tristate where auto detection can't be done.
> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
> ---
> Changes in v2:
> - New patch in this series
> I have chosen to use readl/writel for ARM because
> of barriers and keep __raw versions for microblaze
> and ppc where this is not a problem.
> The reason why in_be32/out_be32 can't be used
> is that it won't work on Microblaze LE when
> I fix Microblaze IO function implementation which
> is broken right now.

Makes perfect sense.

Patch applied.

Linus Walleij
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at