Re: [PATCH V2] i2c: designware: fix race between subsequent xfers
From: Christian Ruppert
Date: Mon Jun 17 2013 - 04:20:42 EST
On Fri, Jun 14, 2013 at 04:37:41PM +0200, Wolfram Sang wrote:
> On Fri, Jun 07, 2013 at 10:51:23AM +0200, Christian Ruppert wrote:
> > + /*
> > + * We must disable the adapter before unlocking the &dev->lock mutex
> > + * below. Otherwise the hardware might continue generating interrupts
> > + * which in turn causes a race condition with the following transfer.
> I added "Needs some more investigation if the additional interrupts are
> a hardware bug or this driver doesn't handle them correctly yet." to the
> comment and
Good idea, thanks.
> Applied to for-next, thanks!
> BTW since I am currently here: i2c-designware-core should be in the
> 'algos' directory, no?
At the risk of passing for a complete moron: What exactly is the
difference between I2C algos and I2C bus drivers?
Christian Ruppert , <christian.ruppert@xxxxxxxxxx>
Tel: +41/(0)22 816 19-42 //| 3, Chemin du Pré-Fleuri
_// | bilis Systems CH-1228 Plan-les-Ouates
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/