Re: [PATCH 1/2] Initial support for Allwinner's Security ID fuses

From: Oliver Schinagl
Date: Mon Jun 17 2013 - 09:52:55 EST

On 17-06-13 15:23, Tomasz Figa wrote:
On Monday 17 of June 2013 15:10:47 Oliver Schinagl wrote:
On 17-06-13 14:51, Tomasz Figa wrote:
On Monday 17 of June 2013 12:36:47 Oliver Schinagl wrote:
On 15-06-13 12:28, Tomasz Figa wrote:
Now we pass this array to add_randomness(array, 16). So add_randomness
sees 16 ints in an array. So while there will be a lot of extra zero's,
there still be 16 elements copied/processed, no?

The second argument of add_randomness is number of bytes, not number of
elements in array, as far as I can tell.
Oh wow, very good catch. I had to dig a little into the source where it
said 'nbytes'. I guess the function prototype would have been nicer if it
said nbytes instead of size.

Anyway, with using an array of u8 this is nicely handled.

Best regards,

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at