Re: [PATCH 2/3] tracing/kprobes: Kill probe_enable_lock
From: Oleg Nesterov
Date: Mon Jun 17 2013 - 11:23:20 EST
On 06/17, Masami Hiramatsu wrote:
> (2013/06/17 2:21), Oleg Nesterov wrote:
> > enable_trace_probe() and disable_trace_probe() should not worry about
> > serialization, the caller (perf_trace_init or __ftrace_set_clr_event)
> > holds event_mutex.
> > They are also called by kprobe_trace_self_tests_init(), but this __init
> > function can't race with itself or trace_events.c
> For safety, we should comment this at the caller side,
Which caller do you mean?
The patch adds
* This and enable_trace_probe/disable_trace_probe rely on event_mutex
* held by the caller, __ftrace_set_clr_event().
above trace_probe_nr_files() but the next patch removes this function
with the comment...
Will you agree with this patch if I add something like
* called by perf_trace_init() or __ftrace_set_clr_event() under event_mutex
above kprobe_register() ? Perhaps it makes sense to add
lockdep_assert_held(&event_mutex) into the body?
> those calls are the reason why I have introduced this lock.
Please do not hesitate to nack this patch if you think that we should
keep probe_enable_lock for safety even if it is not currently needed.
In this case I'd suggest to move lock/unlock into kprobe_register()
but this is minor.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/