Re: [RFC patch 2/4] sched/tg: use 'unsigned long' for load variablein task group

From: Alex Shi
Date: Mon Jun 17 2013 - 11:27:20 EST


On 06/17/2013 08:25 PM, Paul Turner wrote:
> On Fri, Jun 7, 2013 at 12:29 AM, Alex Shi <alex.shi@xxxxxxxxx> wrote:
>> > Since tg->load_avg is smaller than tg->load_weight, we don't need a
>> > atomic64_t variable for load_avg in 32 bit machine.
>> > The same reason for cfs_rq->tg_load_contrib.
> This description is incorrect, another patch removes tg->load_weight
> for being unused.

You can say this, but tg->load_weight was designed for the same meaning
as load_avg before. :)
>
> Rest seems fine.

thanks for review.

--
Thanks
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/