Re: [PATCH v2] pinctrl: rockchip: correctly handle arguments ofpinconf options

From: Linus Walleij
Date: Mon Jun 17 2013 - 11:48:28 EST

On Sun, Jun 16, 2013 at 5:41 PM, Heiko Stübner <heiko@xxxxxxxxx> wrote:

> Change the rockchip pinctrl driver to handle the arguments to the pull
> pinconfig options correctly. So only accept non-0 values for the
> pull options as the rockchip pin-controller can only turn pulls on and
> off (this via BIAS_DISABLE).
> Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx>
> ---
> changes since v1:
> really respect the values for arguments of the pull options (aka 0 is not
> meant to turn off a pull).
> Replacing the patch also makes sure that no wrong knowledge stays in the
> kernel via the old commit message, least somebody else reads it and takes
> it as true.

OK took out the v1 and put in this v2 version instead...

Linus Walleij
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at