Re: [PATCH 1/4] MFD: Palmas: Add Interrupt feature

From: Mark Brown
Date: Mon Jun 17 2013 - 12:16:49 EST


On Mon, Jun 17, 2013 at 05:39:11PM +0530, J Keerthy wrote:

> Palmas PMICs have an INT line. This line is one single
> Interrupt line to the application processor. The interrupt
> feature enables to selectively request irq for only those
> specific chips which have INT line connected to a valid
> IRQ line of the application processor.

Does the support for the interrupt line need to be explicitly flagged
like this or can the driver not simply support an interrupt line not
being configured? That would also support cases where the hardware has
an interrupt line but the system integrator has opeted not to connect it
for some reason which seems generally more flexible than doing things on
a chip ID basis.

> +/**
> + * DOC: Palmas PMIC feature types
> + *

Is "DOC: " normal kerneldoc?

Attachment: signature.asc
Description: Digital signature