Re: +mm-thp-dont-use-hpage_shift-in-transparent-hugepage-code.patch added to -mmtree
From: Andrew Morton
Date: Mon Jun 17 2013 - 17:29:21 EST
On Mon, 17 Jun 2013 16:27:46 +0300 "Kirill A. Shutemov" <kirill@xxxxxxxxxxxxx> wrote:
> On Mon, May 13, 2013 at 04:14:06PM -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> > From: "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxxxxxxxxxx>
> > Subject: mm/THP: don't use HPAGE_SHIFT in transparent hugepage code
> > For architectures like powerpc that support multiple explicit hugepage
> > sizes, HPAGE_SHIFT indicate the default explicit hugepage shift. For THP
> > to work the hugepage size should be same as PMD_SIZE. So use PMD_SHIFT
> > directly. So move the define outside CONFIG_TRANSPARENT_HUGEPAGE #ifdef
> > because we want to use these defines in generic code with if
> > (pmd_trans_huge()) conditional.
> I would propose to partly revert the patch with the patch bellow.
It's not completely clear what you're proposing here. Can you send a
real patch against mmotm or -next for us to look at?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/