RE: [PATCH 1/4] MFD: Palmas: Add Interrupt feature

Date: Tue Jun 18 2013 - 01:15:37 EST

Hi Mark,

Thanks for the review.

> -----Original Message-----
> From: Mark Brown [mailto:broonie@xxxxxxxxxx]
> Sent: Monday, June 17, 2013 9:46 PM
> Cc: linux-omap@xxxxxxxxxxxxxxx; ldewangan@xxxxxxxxxx;
> sameo@xxxxxxxxxxxxxxx; grant.likely@xxxxxxxxxxxx; swarren@xxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx;
> gg@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/4] MFD: Palmas: Add Interrupt feature
> On Mon, Jun 17, 2013 at 05:39:11PM +0530, J Keerthy wrote:
> > Palmas PMICs have an INT line. This line is one single Interrupt line
> > to the application processor. The interrupt feature enables to
> > selectively request irq for only those specific chips which have INT
> > line connected to a valid IRQ line of the application processor.
> Does the support for the interrupt line need to be explicitly flagged
> like this or can the driver not simply support an interrupt line not
> being configured? That would also support cases where the hardware has
> an interrupt line but the system integrator has opeted not to connect
> it for some reason which seems generally more flexible than doing
> things on a chip ID basis.

I understand your point. The IRQ is passed from device tree node.
Say if the chip for some reason is not connected to any valid
IRQ line the driver might end up requesting for a wrong IRQ line.

So should I be validating the irq entry populated from device tree?

Explicitly checking on chip ID helps to avoid wrongly populated
Device tree data.

> > +/**
> > + * DOC: Palmas PMIC feature types
> > + *
> Is "DOC: " normal kerneldoc?

Normal kerneldoc I shall remove "DOC:"

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at