Re: [PATCH 1/4] MFD: Palmas: Add Interrupt feature

From: Mark Brown
Date: Tue Jun 18 2013 - 04:58:46 EST

On Tue, Jun 18, 2013 at 05:15:03AM +0000, J, KEERTHY wrote:

> I understand your point. The IRQ is passed from device tree node.
> Say if the chip for some reason is not connected to any valid
> IRQ line the driver might end up requesting for a wrong IRQ line.

> So should I be validating the irq entry populated from device tree?

Yes, you should be checking that there's actually an interrupt there -
the number will be zero if there isn't.

> Explicitly checking on chip ID helps to avoid wrongly populated
> Device tree data.

Right, but on the other hand it ought to be possible to handle chips
that could but aren't configured to do interrupts and if the driver can
do that then this becomes redundant.

Attachment: signature.asc
Description: Digital signature