Re: [PATCH v7 2/9] usb: phy: omap-usb2: use the new generic PHYframework
From: Felipe Balbi
Date: Tue Jun 18 2013 - 05:52:46 EST
On Tue, Jun 18, 2013 at 03:19:03PM +0530, Kishon Vijay Abraham I wrote:
> On Tuesday 18 June 2013 03:10 PM, Felipe Balbi wrote:
> >On Thu, Jun 13, 2013 at 02:13:52PM +0530, Kishon Vijay Abraham I wrote:
> >>@@ -159,6 +191,12 @@ static int omap_usb2_probe(struct platform_device *pdev)
> >> otg->start_srp = omap_usb_start_srp;
> >> otg->phy = &phy->phy;
> >>+ pm_runtime_enable(phy->dev);
> >enabling pm_runtime here has the potential to cause a real big problem.
> >How have you tested this patch ?
> performed boot and enumeration testing. What issue do you expect here?
hint: look at drvdata usage around the driver. Where is it initialized ?
Where is it used ?
Description: Digital signature