Re: [ext3,ext4] old bug in htree_dirblock_to_tree()

From: Theodore Ts'o
Date: Tue Jun 18 2013 - 12:01:32 EST


On Mon, Jun 17, 2013 at 04:23:38PM +0100, Al Viro wrote:
> Both ext3 and ext4 htree_dirblock_to_tree() is just filling
> the in-core rbtree for use by call_filldir(). All updates of
> ->f_pos are done by the latter; bumping it here (on error) is obviously
> wrong - we might very well have it nowhere near the block we'd found
> an error in.
>
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>

Applied, thanks. Nice catch!

Jan, I'll carry the fix for ext3 as well in the ext4 tree, unless
you'd prefer otherwise.

- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/