Re: [PATCH 2/3] sched: don't call get_group() for covered cpus
From: Peter Zijlstra
Date: Tue Jun 18 2013 - 13:30:49 EST
On Tue, Jun 18, 2013 at 08:59:39PM +0530, Viresh Kumar wrote:
> On 18 June 2013 20:49, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> > Sure. Just send a new patch and I'll substitute.
> This is the new log (patch is attached):
> sched: Fix memory leakage in build_sched_groups()
> In build_sched_groups() we don't need to call get_group() for cpus which are
> already covered in previous iterations. Calling get_group() would mark the group
> used and eventually leak it since we wouldn't connect it and not find it again
> to free it.
> This will happen only in cases where sg->cpumask contained more than one cpu
> (For any topology level). This patch would free sg's memory for all cpus leaving
> the group leader as the group isn't marked used now.
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/