Re: [PATCH 2/2] spi/pxa2xx: use a flag to check if the device isruntime suspended

From: Mark Brown
Date: Tue Jun 18 2013 - 14:09:56 EST


On Tue, Jun 18, 2013 at 05:29:45PM +0300, Mika Westerberg wrote:
> Current code calls pm_runtime_suspended() in the interrupt handler to check
> if the device is suspended or not. However, runtime PM status of the device
> is only set to suspended once all PM runtime suspend hooks have executed.

> In our case we have the device bound to the ACPI power domain and its
> runtime suspend hook will put the device to D3hot (or D3cold if possible).
> This effectively means that the device is powered off before its state is
> set to runtime suspended. During this time, it might get an interrupt that
> is meant for another device (as the interrupt line is shared), and because
> the device is powered off accessing its registers will return 0xffffffff
> that the driver misinterprets as an invalid state. When this happens user
> will see messages like below on the console:

This sounds like a problem which will affect a lot of devices and hence
ought to be handled better by the PM core or at least frameworks in
general. Is it really device specific?

Attachment: signature.asc
Description: Digital signature