Re: [PATCH v2 1/4] mfd: Kontron PLD mfd driver

[Thomas Gleixner]

On Tue, 18 Jun 2013, Kevin Strasser wrote:

This patch set looks reasonable now, except a formal issue.
 
> Signed-off-by: Kevin Strasser <kevin.strasser@xxxxxxxxxxxxxxx>
> Signed-off-by: Michael Brunner <michael.brunner@xxxxxxxxxxx>

This is wrong, as it says:

 Kevin authored the code, sent it to Michael and Michael sent it to
 LKML.


The original code was authored by Michael. This version was authored
by Kevin based on Michaels code.

So either you keep Michael as the author, then you want 

 From: Michael Brunner <michael.brunner@xxxxxxxxxxx>

 <patch description/>

 Signed-off-by: Michael Brunner <michael.brunner@xxxxxxxxxxx>
 Signed-off-by: Kevin Strasser <kevin.strasser@xxxxxxxxxxxxxxx>

or you decide that it's a major rewrite by you, then you want:

 This patch is based on the original version authored by
 Michael Brunner <michael.brunner@xxxxxxxxxxx>.

 Signed-off-by: Kevin Strasser <kevin.strasser@xxxxxxxxxxxxxxx>

 Or 

 Originally-From: Michael Brunner <michael.brunner@xxxxxxxxxxx>.
 Signed-off-by: Kevin Strasser <kevin.strasser@xxxxxxxxxxxxxxx>

Other than that.

Acked-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/