Re: [PATCH v2 1/2] mfd: tps65910: Fix crash in i2c_driver .probe
From: Wolfram Sang
Date: Wed Jun 19 2013 - 05:58:25 EST
On Wed, Jun 19, 2013 at 10:27:40AM +0200, Samuel Ortiz wrote:
> Hi Lee,
> On Wed, Jun 19, 2013 at 09:18:59AM +0100, Lee Jones wrote:
> > On Tue, 18 Jun 2013, Tuomas Tynkkynen wrote:
> > > Commit "i2c: core: make it possible to match a pure device tree driver"
> > > changed semantics of the i2c probing for device tree devices.
> > > Device tree probed devices now get a NULL i2c_device_id pointer.
> > > This caused kernel panics due to NULL dereference.
> > >
> > > Moves the of_match_device call from tps65910_parse_dt to .probe to
> > > allow the chip type to be detected from device tree but with the
> > > device parameters coming from platform data.
> > >
> > > Signed-off-by: Tuomas Tynkkynen <ttynkkynen@xxxxxxxxxx>
> > Applied with Stephen's Reviewed-by, thanks.
> According to Wolfgang, this is not needed as he will revert the i2c
> commits that are causing those crashes.
> I would not take it for now.
"Wolfram", please ;) Otherwise correct.
Description: Digital signature