Re: [PATCH v3] sound/sgtl5000: fix codec register initial values andhandling

From: Mark Brown
Date: Wed Jun 19 2013 - 11:27:01 EST

On Wed, Jun 19, 2013 at 01:16:06PM +0000, Oskar Schirmer wrote:

This is a set of three unrelated changes, they should be sent as three
separate patches.

> Further, mask computation in declarative part is obviously wrong:
> Fix FRAC DIVISOR to provide an 11 bit mask correctly.

What makes you say that this is obviously wrong? It's not entirely

> -#define SGTL5000_PLL_FRAC_DIV_MASK 0x0700
> +#define SGTL5000_PLL_FRAC_DIV_MASK 0x07ff

Based on your changelog I was expecting a mask with only two bits set

Attachment: signature.asc
Description: Digital signature