Re: [PATCH V6 03/30] thermal: exynos: Remove un-necessary CPU_THERMALdependency

From: Eduardo Valentin
Date: Wed Jun 19 2013 - 14:49:05 EST


On 17-06-2013 02:46, Amit Daniel Kachhap wrote:
> This patch removes the dependency on CPU_THERMAL for compiling TMU driver.
> This is useful for cases when only TMU controller needs to be initialised
> without cpu cooling action.
>
> Acked-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx>
> Acked-by: Jonghwa Lee <jonghwa3.lee@xxxxxxxxxxx>
> Signed-off-by: Amit Daniel Kachhap <amit.daniel@xxxxxxxxxxx>


Acked-by: Eduardo Valentin <eduardo.valentin@xxxxxx>

Please have a look on my comment on your patch 04. You may want to have
this dependency still on your core part.

> ---
> drivers/thermal/samsung/Kconfig | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig
> index 883a8a8..2cf31ad 100644
> --- a/drivers/thermal/samsung/Kconfig
> +++ b/drivers/thermal/samsung/Kconfig
> @@ -1,7 +1,6 @@
> config EXYNOS_THERMAL
> tristate "Temperature sensor on Samsung EXYNOS"
> depends on ARCH_HAS_BANDGAP
> - depends on CPU_THERMAL
> help
> If you say yes here you get support for TMU (Thermal Management
> Unit) on SAMSUNG EXYNOS series of SoC. This helps in registering
>


--
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin

Attachment: signature.asc
Description: OpenPGP digital signature