Re: [PATCH v5] cpufreq: fix governor start/stop race condition
From: Rafael J. Wysocki
Date: Wed Jun 19 2013 - 18:39:53 EST
On Wednesday, June 19, 2013 08:30:11 AM Viresh Kumar wrote:
> On 19 June 2013 06:50, Xiaoguang Chen <chenxg.marvell@xxxxxxxxx> wrote:
> > 2013/6/19 Rafael J. Wysocki <rjw@xxxxxxx>:
> >> On Thursday, June 13, 2013 05:01:58 PM Xiaoguang Chen wrote:
> >>> cpufreq governor stop and start should be kept in sequence.
> >>> If not, there will be unexpected behavior, for example:
> >>> we have 4 cpus and policy->cpu=cpu0, cpu1/2/3 are linked to cpu0.
> >> Please spell cpus as "CPUs". And please start sequences from capitals.
> > Ok, thanks for the remind
> >> [Yes, it *really* is a problem.]
> Just wanted to know the reasoning behind it so that I can remind
> others about it and then argue :)
Well, sentences that don't start from upper-case letters don't look like
separate sentences and when I see "cpus" written like this I tend to read
it as "cups" with a typo.
Generally speaking, don't make changelogs harder to read than they have to be.
They usually are hard enough to read anyway.
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/