Re: [PATCH] mv643xx_eth: Fix a DMA-API error handling warning
From: David Miller
Date: Thu Jun 20 2013 - 01:18:21 EST
From: Lubomir Rintel <lkundrak@xxxxx>
Date: Tue, 18 Jun 2013 19:33:28 +0200
> We check the failure status just prior to unmap, since it would be too much of
> a hassle to roll back commands we already started to enqueue if we handled it
> just after the map.
> This way we at least avoid a lockup on reclaim, the card presumably didn't
> succeed DMA-ing to a bogus address anyway.
You have to handle it at map time, I don't care how complicated it is.
As is, when a DMA mapping failure occurs the chip is crapping into
random memory. At that point, who cares what you decide to do about
it at unmap time?
This patch is unacceptable, sorry.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/