Re: [PATCH V6 3/3] ARM: dts: Add pcie controller node for SamsungEXYNOS5440 SoC

From: Thomas Petazzoni
Date: Thu Jun 20 2013 - 04:00:26 EST

Dear Jingoo Han,

On Thu, 20 Jun 2013 16:57:32 +0900, Jingoo Han wrote:

> > > - pinctrl {
> > > + pin_ctrl: pinctrl {
> > > compatible = "samsung,exynos5440-pinctrl";
> >
> > I know I'm nitpicking, but isn't this change completely unrelated to
> > PCIe support?
> This change is related to PCIe support.
> Without this, I cannot use gpio binding.
> This change was guided by Thomas Abraham (Author of Samsung pinctrl).
> Also, it was confirmed by Kukjin Kim (Maintainer of Samsung SoC).
> Thank you for your caring. :)

I mean, the change is fine for sure, but it should maybe part of a
separate patch as it is more a fix than really the introduction of the
PCIe controller node, as the patch title suggests. This would also for
example allow this fix to be merged right now (for 3.11), regardless of
what happens for the rest of your PCIe patches.

Best regards,

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at