Re: [PATCH] gpio: msm-v1: Remove errant __devinit to fix compile
From: Olof Johansson
Date: Thu Jun 20 2013 - 21:48:27 EST
On Tue, Jun 18, 2013 at 11:16:17AM +0200, Linus Walleij wrote:
> On Mon, Jun 17, 2013 at 7:14 PM, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote:
> > On 06/16/13 22:54, Linus Walleij wrote:
> >> On Tue, Jun 4, 2013 at 9:20 PM, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote:
> >>> Commit 7bce696 (gpio: Make gpio-msm-v1 into a platform driver,
> >>> 2013-03-04) was based on an older kernel where __devinit still
> >>> existed. Remove the erroneous __devinit marking.
> >>> Cc: David Brown <davidb@xxxxxxxxxxxxxx>
> >>> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> >> Patch applied.
> > Thanks. It looks like David picked this up and sent it off to arm-soc
> > last week. Cc'ing Olof for awareness of a possible duplicate.
> Did that get ack by some GPIO maintainer?
> This needs to go through the GPIO tree, but I
> guess GIT will survive if it ends up in two trees.
Nope, and it slipped through the cracks. More and more patches that we see lack
proper acks, and it's becoming a problem. I have to go search for them on the
lists and see if they came in without being tagged on the patch, etc.
Time to get more strict on that, obviously. :(
But yeah, one duplicate trivial patch like this shouldn't be an issue.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/