Re: [PATCH 2/4] time: add a notifier chain for when the system timeis stepped
From: John Stultz
Date: Fri Jun 21 2013 - 12:22:54 EST
On 06/21/2013 12:57 AM, Thomas Gleixner wrote:
On Thu, 20 Jun 2013, David Vrabel wrote:
From: David Vrabel <david.vrabel@xxxxxxxxxx>You fail to explain why any other part of the kernel requires a
The high resolution timer code gets notified of step changes to the
system time with clock_was_set() or clock_was_set_delayed() calls. If
other parts of the kernel require similar notification there is no
clear place to hook into.
We went great length to confine timekeeping inside the core code and
now you add random notifiers along with totally ugly tasklet
constructs. What for?
Without a reasonable explanation of the problem you are trying to
solve this is going nowhere near the tree.
It took awhile for me to get why it was needed as well.
My understanding is that on Xen, they want the hypervisor's virtual RTC
needs to be aligned with Dom0s system time (so that DomN guests boot
with the correct time). Thus changes to the system time need to cause
Dom0 to update the virtual RTC.
Its not terribly unlike the timerfd notification we do to userspace, but
instead is done for the Dom0 Xen management code.
I do agree we need to keep users of the notification on a short leash
(hopefully keeping the interface behind some sort of internal.h header
file) so its easy to see when folks start trying to use it.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/