Re: [PATCH 1/4] hrtimers: provide a hrtimers_late_resume() call

From: Thomas Gleixner
Date: Fri Jun 21 2013 - 17:24:13 EST

On Fri, 21 Jun 2013, David Vrabel wrote:
> On 21/06/13 15:32, Thomas Gleixner wrote:
> However, since hrtimers require the use of a one-shot ticker and when
> one-shot timers are resumed they are armed to fire immediately (see
> tick_resume_oneshot()) this interrupt is sufficient to kick the require
> softirq.
> So, as proposed before:
> hrtimers_resume()
> {
> /* This CPU's tick is armed to fire immediately by
> tick_oneshot_resume(). Just need raise a softirq to program
> the timers on all CPUs. */
> cpu_base->clock_was_set = 1;
> __raise_softirq_irqoff(HRTIMER_SOFTIRQ);
> }
> Do you agree or disagree?

Fair enough. I did not think about that. With the comment in place it
is clear. It might be a bit more elaborate for the casual reader.



To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at