Re: [PATCHv2 1/3] iio: Add Nuvoton NAU7802 ADC driver
From: Alexandre Belloni
Date: Sat Jun 22 2013 - 09:08:10 EST
On 22/06/2013 14:02, Lars-Peter Clausen wrote:
> On 06/22/2013 01:55 PM, Jonathan Cameron wrote:
>> On 06/20/2013 07:57 PM, Alexandre Belloni wrote:
>>> The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable
>>> gain and sampling rates.
>> Sorry, somewhat low on time today so only a quick review.
>> 1) Missing userspace ABI documentation. Also, perhaps min_conversions is
>> a little vague? Not that I have a better idea!
> I really don't like the name min_conversions either. Isn't this effectively
> a decimation filter?
Yeah, it could be seen like that but it is only relevant and only
happens when switching between channels. I'm open to any ideas.
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/