Re: [PATCH] net: fec: Fix multicast list setup in fec_restart().

From: Fabio Estevam
Date: Thu Jun 27 2013 - 13:21:42 EST


On Thu, Jun 27, 2013 at 2:14 PM, Christoph MÃllner
<christoph.muellner@xxxxxxxxxxxxxxxxxxxxx> wrote:

> Is updated in the attached patch.
> Thank you for the feedback!

Looks good. Some suggestions:

- Mark the patch as the second version:
Subject: [PATCH v2] net: fec: Fix multicast list setup in fec_restart().

- Add a comment below the --- line explaining what you changed in v2.

Something like:

---
Changes since v1:
- Adapt the comment to the code change

- Then re-send it via git send-email to the list instead of sending it
via attachment.

Thanks,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/