Re: [PATCH] m68k/setup: Use pr_*() instead of plain printk()

[Geert Uytterhoeven]

On Mon, Jul 1, 2013 at 12:22 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
>> diff --git a/arch/m68k/kernel/setup_mm.c b/arch/m68k/kernel/setup_mm.c
>
>> @@ -161,7 +161,7 @@ static void __init m68k_parse_bootinfo(const struct bi_record *record)
> []
>> -                             printk("m68k_parse_bootinfo: too many memory chunks\n");
>> +                             pr_warn("m68k_parse_bootinfo: too many memory chunks\n");
>
> These are generally better written by
> removing the hand-written function name
> and using "%s: ", __func__
>
>                                 pr_warn("%s: too many memory chunks\n",
>                                         __func__);

I had tried that, too. But surprisingly (although the same function
name was in two
messages), it increased the size of the kernel image.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/