Re: [PATCH] Define WTERMSIG{,_MASK} and WCOREDUMP and use whereappropriate

[Oleg Nesterov]

On 07/01, Denys Vlasenko wrote:
>
> Grepping for numeric constants is inconvenient.

Personally I agree very much, and I like the intent.

> +#define WTERMSIG_MASK     0x7f
> +#define WTERMSIG(status)  ((status) & WTERMSIG_MASK)
> +#define WCOREDUMP(status) ((status) & 0x80)

But I am not sure we need WTERMSIG/WCOREDUMP helpers, although
I won't really argue.

OTOH, I think it would be nice to add the name for 0x80 and
change coredump_finish().

And if we do not add WTERMSIG(), then perhaps we can turn other
0x7f's into WTERMSIG_MASK?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/