Re: [PATCH 05/13] android/sync: use get_unused_fd_flags(0) instead of get_unused_fd()

From: Erik Gilling
Date: Tue Jul 02 2013 - 18:22:38 EST


On Tue, Jul 2, 2013 at 9:39 AM, Yann Droneaud <ydroneaud@xxxxxxxxxx> wrote:
> static long sync_fence_ioctl_merge(struct sync_fence *fence, unsigned long arg)
> {
> - int fd = get_unused_fd();
> + int fd = get_unused_fd_flags(0);

I think we should use O_CLOEXEC here. Colin and I can't think of any
case where one would want keep fences across exec.

Cheers,
Erik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/