Re: [PATCH 1/3] clocksource: clean up clocksource_select

From: Alex Shi
Date: Thu Jul 04 2013 - 06:23:01 EST



> We need this check and it is completely unrelated to the problem
> you're trying to solve.
>
> Assume the following:
>
> System boots with clocksource A and switches into highres mode.
> Now clocksource B gets registered and B is not highres capable.
>
> clocksource_find_best() selects again A, but we have
> clocksource=B on the kernel command line to override the kernel
> decision.
>
> By removing the check, you install he non highres capable clocksource
> B and kill the machine.
>

You'r right. my bad, Sorry!

BTW, why we allow user override a second best clocksource? I mean user
can override the tsc with hpet. because undetected unstable tsc?



--
Thanks
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/