Re: [PATCH 1/3] arch/um/Makefile: remove dead code

[Richard Weinberger]

Am 04.07.2013 23:03, schrieb Ramkumar Ramachandra:
> arch/um/Makefile is included in the toplevel Makefile:495.  Well before
> that, it unconditionally sets $SUBARCH (in Makefile:168) as follows:
> 
>   SUBARCH := $(shell uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ \
> 				    -e s/sun4u/sparc64/ \
> 				    -e s/arm.*/arm/ -e s/sa110/arm/ \
> 				    -e s/s390x/s390/ -e s/parisc64/parisc/ \
> 				    -e s/ppc.*/powerpc/ -e s/mips.*/mips/ \
> 				    -e s/sh[234].*/sh/ -e s/aarch64.*/arm64/ )
> 
> It is clearly impossible for $SUBARCH to be set as i386 or x86_64.
> Therefore, any code that checks $SUBARCH against these values is dead
> code.

No.
If you build UML for x86_64 you override SUBARCH.
i.e. make linux ARCH=um SUBARCH=x86_64

> Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> Cc: Richard Weinberger <richard@xxxxxx>
> Cc: Jeff Dike <jdike@xxxxxxxxxxx>
> Signed-off-by: Ramkumar Ramachandra <artagnon@xxxxxxxxx>

NAK.

Thanks,
//richard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/