Re: [PATCH v2] arch: asm-generic: for atomic_set_mask() 1st param,use 'unsigned int' instead of 'unsigned long'

[Chen Gang]

Hello Maintainers:

Please help check this patch whether OK, when you have time.

Thanks.

On 06/26/2013 10:03 AM, Chen Gang wrote:
> Hello Maintainers:
> 
> Firstly thank the s390 maintainers again for their 'Acked-by' (in my
> memory, s390 is the most important business mainframe machine)
> 
> Could another related maintainers give a glance for it, when you have time.
> 
> Thanks.
> 
> On 06/13/2013 09:19 AM, Chen Gang wrote:
>> On 06/10/2013 05:21 PM, Heiko Carstens wrote:
>>> On Sun, Jun 09, 2013 at 02:31:42PM +0800, Chen Gang wrote:
>>>>>
>>>>> atomic_set_mask() and atomic_clear_mask() are the pairs, so the related
>>>>> parameters' type need match with each other.
>>>>>
>>>>> The type of 'addr->counter' is 'int', so use 'unsigned int' instead
>>>>> of 'unsigned long', and let atomic_set_mask() match atomic_clear_mask().
>>>>>
>>>>>
>>>>> For arch sub-system, currently, have 3 types of definition for them:
>>>>> 1st for 'int', 2nd for 'long', 3rd is conflict to use 'int' and 'long'.
>>>>>
>>>>> At least, better to fix 3rd (conflict using 'int' and 'long').
>>>>>
>>>>> Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx>
>>>>> ---
>>>>>  arch/blackfin/include/asm/atomic.h |    4 ++--
>>>>>  arch/m32r/include/asm/atomic.h     |    8 ++++----
>>>>>  arch/s390/include/asm/atomic.h     |    4 ++--
>>>>>  include/asm-generic/atomic.h       |    2 +-
>>>>>  4 files changed, 9 insertions(+), 9 deletions(-)
>>> For the s390 part:
>>>
>>> Acked-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
>>>
>>
>> Thank you very much !!
>>
>>
> 
> 


-- 
Chen Gang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/