Re: [merged] memstick-add-support-for-legacy-memorysticks.patch removed from -mm tree

From: Valdis . Kletnieks
Date: Mon Jul 08 2013 - 02:04:41 EST


On Mon, 08 Jul 2013 03:41:42 +0300, Maxim Levitsky said:

> +/* Debug test to validate free block counts */
> +#ifdef DEBUG
> +static int msb_validate_used_block_bitmap(struct msb_data *msb)
> +{

Is there a reason this should be inside a #ifdef DEBUG with no
easy way to select DEBUG? Maybe CONFIG_MS_BLOCK_DEBUG similar to
the way other subsystems allow configuring additional debug code?

Attachment: pgp00000.pgp
Description: PGP signature