Re: [GIT PULL] Stage 1 of __cpuinit removal

From: Paul Gortmaker
Date: Mon Jul 08 2013 - 02:04:44 EST


[Re: [GIT PULL] Stage 1 of __cpuinit removal] On 07/07/2013 (Sun 11:07) Linus Torvalds wrote:

> On Tue, Jul 2, 2013 at 10:44 AM, Paul Gortmaker
> <paul.gortmaker@xxxxxxxxxxxxx> wrote:
> >
> > include/asm-generic/vmlinux.lds.h | 12 ---------
> > include/linux/init.h | 19 +++++++-------
> > scripts/mod/modpost.c | 52 +++++++--------------------------------
> > 3 files changed, 19 insertions(+), 65 deletions(-)
>
> Your diffstat is odd, and doesn't match mine. But I'm pretty sure
> yours is just plain wrong, because your numbers just don't add up.
>
> You have:
> 12+19+52 = 83
> 19+65 = 84
>
> how the heck did you manage that?

I must have fat fingered it in vim/mutt under screen with a stray
Ctrl-A (increase number), since I still have the raw output from
git request-pull that I pulled into mutt and it is sane and correct.

------
$ ls -l prq
-rw-rw-r-- 1 paul paul 845 Jul 2 13:11 prq
$ grep changed prq
3 files changed, 18 insertions(+), 65 deletions(-)
------

Sorry about the confusion.

Paul.
--

>
> The correct diffstat would seem to be
>
> include/asm-generic/vmlinux.lds.h | 12 ------------
> include/linux/init.h | 19 +++++++++---------
> scripts/mod/modpost.c | 52
> +++++++++----------------------------------------
> 3 files changed, 18 insertions(+), 65 deletions(-)
>
> (where both set of numbers add up to 83).
>
> Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/