Re: [RFC PATCH 08/13] sound: sam9x5_wm8731: machine driver forat91sam9x5 wm8731 boards

[Richard Genoud]

2013/7/8 Bo Shen <voice.shen@xxxxxxxxx>:
> Hi Richard,
>
>
> On 7/5/2013 23:15, Richard Genoud wrote:
>>>>
>>>> +       card->dev = &pdev->dev;
>>>> >>+       card->owner = THIS_MODULE;
>>>> >>+       card->dai_link = dai;
>>>> >>+       card->num_links = 1;
>>>> >>+       dai->name = "WM8731";
>>>> >>+       dai->stream_name = "WM8731 PCM";
>>>> >>+       dai->codec_dai_name = "wm8731-hifi";
>>>> >>+       dai->init = at91sam9x5ek_wm8731_init;
>>>> >>+       card->dapm_widgets = at91sam9x5ek_dapm_widgets;
>>>> >>+       card->num_dapm_widgets =
>>>> >> ARRAY_SIZE(at91sam9x5ek_dapm_widgets);
>>>
>>> >
>>> >
>>> >Will keep these as snd_soc_card and snd_soc_dai_link structure
>>> > separately?
>>
>> I don't really understand what you mean here.
>> do you mean that something like that will more explicit ? :
>> +       card->dai_link[0].name = "WM8731";
>> +       card->dai_link[0].stream_name = "WM8731 PCM";
>> +       card->dai_link[0].codec_dai_name = "wm8731-hifi";
>> +       card->dai_link[0].init = at91sam9x5ek_wm8731_init;
>>
>
> I mean using structure to define snd_soc_card and snd_soc_dai_link, look
> like:
> struct snd_soc_dai_link dai_link_name = {
>         .name = xxx,
>         .stream_name = xxx,
>         ...
> };
>
> struct snd_soc_card card_name = {
>         .name = xxxx
>         .ower = THIS_MODULE,
>         .dai_link = &dai_link_name,
>         ...
> };
>
> In this way, I think it will be more clear than put them in code.

ok, got it !

Thanks !

Richard.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/