Re: [RFC] [PATCH 1/2 v2] x86: introduce int3-based instruction patching

[H. Peter Anvin]

On 07/11/2013 03:23 AM, Masami Hiramatsu wrote:
>> + *
>> + * The way it is done:
>> + *	- add a int3 trap to the address that will be patched
>> + *	- sync cores
> 
> You don't need this "sync cores". (and your code didn't) :)
> 

I believe you do, lest you get "Frankenstructions".  I believe you don't
need the second one, however.  I should dig up my notes on this.

>> + *	- update all but the first byte of the patched range
>> + *	- sync cores
>> + *	- replalace the first byte (int3) by the first byte of
>> + *	  replacing opcode
>> + *	- sync cores
>> + *


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/