Re: [PATCH 0/4] iio: hid-sensor: add module alias for autoload

[Alexander Holler]

Am 11.07.2013 19:27, schrieb Srinivas Pandruvada:
> On 07/10/2013 08:58 AM, Alexander Holler wrote:
> > Am 10.07.2013 17:27, schrieb Srinivas Pandruvada:
> > > Hi,
> > >
> > > There was no intention to prevent auto loading. Did you get chance to
> > > test these changes?
> >
> > Sure, I always test patches before I send them out.
> >
> > Ok, I haven't tested the changes with the iio HID drivers (I don't
> > have any commercial HID sensor hub, so I've just compile tested these
> > patches here, double reading them), but I've tested the similiar
> > changes with a patch for rtc-hid-sensor-time I've send out yesterday.
> > (sorry, no link, lkml.org seems dead, just search for
> > "rtc-hid-sensor-time: add module alias")
> >
> > It works just fine. An example output is now
> >
> > Jul  9 19:27:21 dockstar3 kernel: [    5.124444] rtc_hid_sensor_time
> > HID-SENSOR-2000a0.0: milliseconds supported
> > Jul  9 19:27:21 dockstar3 kernel: [    5.132864] rtc_hid_sensor_time
> > HID-SENSOR-2000a0.0: rtc core: setting system clock to 2013-07-09
> > 17:26:51:328000 UTC (1373390811)
> > Jul  9 19:27:21 dockstar3 kernel: [    5.146105] rtc_hid_sensor_time
> > HID-SENSOR-2000a0.0: rtc core: registered hid-sensor-time as rtc0
> >
> > Before the output was e.g.
> >
> > HID-SENSOR-2000a0 HID-SENSOR-2000a0.0: rtc core: registered
> > hid-sensor-time as rtc0
> >
> > instead of the above with the descriptive rtc_hid_sensor_time.
> <Agreed. This is better. >
> > Automatic loading of modules works too and it works on ARM, Intel and
> > AMD as module or static linked. ;)

Do you have tested the patches with a real device? I assume you have one. ;)

Regards,

Alexander Holler

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/