Re: [PATCH 5/5] iio: add configuration option for debug support

From: Jonathan Cameron
Date: Tue Jul 16 2013 - 12:07:08 EST




Lars-Peter Clausen <lars@xxxxxxxxxx> wrote:
>On 07/16/2013 11:58 AM, Jonathan Cameron wrote:
>> On 07/15/2013 03:22 PM, Otavio Salvador wrote:
>>> Signed-off-by: Otavio Salvador <otavio@xxxxxxxxxxxxxxxx>
>> seems a sensible facility to have available.
>>
>> Applied to the togreg branch of iio.git
>
>Can you update the Kconfig help text?

Good point. Will fix!
>
>>> ---
>>> drivers/iio/Kconfig | 7 +++++++
>>> drivers/iio/Makefile | 2 ++
>>> 2 files changed, 9 insertions(+)
>>>
>>> diff --git a/drivers/iio/Kconfig b/drivers/iio/Kconfig
>>> index 9af763a..d1f06f2 100644
>>> --- a/drivers/iio/Kconfig
>>> +++ b/drivers/iio/Kconfig
>>> @@ -12,6 +12,13 @@ menuconfig IIO
>>>
>>> if IIO
>>>
>>> +config IIO_DEBUG
>>> + boolean "Debug support for Industrial I/O"
>>> + depends on DEBUG_KERNEL
>>> + help
>>> + Say "yes" to enable debug messaging (like dev_dbg and pr_debug),
>>> + sysfs, and debugfs support in Industrial I/O subsystem and
>drivers.
>
>This has nothing to do with either sysfs or debugfs support.
>
>>> +
>>> config IIO_BUFFER
>>> bool "Enable buffer support within IIO"
>>> help
>>> diff --git a/drivers/iio/Makefile b/drivers/iio/Makefile
>>> index 7a3866c..6e43e5b 100644
>>> --- a/drivers/iio/Makefile
>>> +++ b/drivers/iio/Makefile
>>> @@ -2,6 +2,8 @@
>>> # Makefile for the industrial I/O core.
>>> #
>>>
>>> +ccflags-$(CONFIG_IIO_DEBUG) := -DDEBUG
>>> +
>>> obj-$(CONFIG_IIO) += industrialio.o
>>> industrialio-y := industrialio-core.o industrialio-event.o inkern.o
>>> industrialio-$(CONFIG_IIO_BUFFER) += industrialio-buffer.o
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio"
>in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>

--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/