Re: [Ksummit-2013-discuss] [ATTEND] How to act on LKML (was: [00/19] 3.10.1-stable review)

[Dan Carpenter]

On Mon, Jul 15, 2013 at 04:15:55PM -0700, Guenter Roeck wrote:
> "Your code breaks the build for every platform. Would you please kindly
> consider fixing it ?"

Something like this: https://lists.launchpad.net/ac100/msg01040.html

"small typo here."

Marc, was obviously dripping with sarcasm when he wrote that, but it
was completely lost on the patch submitter.  I've done that too
where I asked "Are you sure you want to call schedule() while
holding a spinlock()?"  It ended up becoming flame fest and it could
have been avoided if I had said, "You are not allowed to call
shedule() while holding a spinlock."

Also instead of saying "Your code is crap", I prefer to say "This
patch is crap."  I suspect the submitters secretly know I think they
are crap too along with their code, but it's important to maintain
the facade.  :)

One other thing which is tricky is if there is someone whose patches
are so worthless it's just a waste of time.  There have been a
couple times where I've told people to stop submitting patches until
they have a few more years of programming experience.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/