Re: [PATCH v3 0/2] Enable lm90 in Tegra30 and Tegra114.

From: Mikko Perttunen
Date: Wed Jul 17 2013 - 04:24:19 EST


On 07/17/2013 11:17 AM, Wei Ni wrote:
On 07/16/2013 07:14 PM, Wei Ni wrote:
On 07/16/2013 01:13 AM, Stephen Warren wrote:
On 07/15/2013 10:48 AM, Stephen Warren wrote:
On 07/12/2013 01:49 AM, Wei Ni wrote:
Enable thermal sensor lm90 for Tegra30 Cardhu and Tegra114 Dalmore.

I have applied the series to Tegra's for-3.12/dt branch.

Actually, I see the following on Dalmore (although Cardhu works):

[ 29.448539] lm90 0-004c: Register 0x4 read failed (-121)
[ 29.453930] lm90 0-004c: Failed to read convrate register!
[ 29.460034] lm90 0-004c: Register 0x3 read failed (-121)
[ 29.465408] lm90 0-004c: Initialization failed!

So, there's something wrong here, and I've dropped the patch for
Dalmore. Does this patch actually work for you?

I test it with the Chrome u-boot, the lm90 works fine.
But today, if I tried to use the uboot from
git://git.denx.de/u-boot-tegra.git, I can repo your errors, it seems the
i2c can't work, the lm90 driver read register failed.
I traced it, but can't find the root cause yet.

Hi, Stephen
I found the root cause.
In the Chrome u-boot, it will turn on the regulator for the lm90, but in
the upstream u-boot, it didn't do it.
I think this regulator should be handled in the kernel driver, but it
seems the regulator palmas tps65913 didn't be supported on the dalmore yet.
So may be we have to wait the palmas ready on dalmore.

A patch to enable tps65913 on dalmore has already been posted a couple of days
ago by Laxman Dewangan, so this shouldn't be too problematic.


Do you have any suggestions?

Thanks.
Wei.

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/