Re: Re: [PATCH 0/2] [BUGFIX] virtio/console: Fix two bugs of splice_write

From: Yoshihiro YUNOMAE
Date: Fri Jul 19 2013 - 01:48:28 EST



(2013/07/19 14:23), Amit Shah wrote:
On (Fri) 19 Jul 2013 [08:19:27], Yoshihiro YUNOMAE wrote:
Hi,

This patch set fixes two bugs of splice_write in the virtio-console driver.

[BUG1] Although pipe->nrbufs is empty, the driver tries to do splice_write.
=> This induces oops in sg_init_table().

[BUG2] No lock for competition of splice_write.
=> This induces oops in splice_from_pipe_feed() by bug of any user
application.

Spotted a bug in the 2nd patch. Do you want to also CC these to stable@?

Sure! I'll CC stable@ and virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxxx
Thanks!

Yoshihiro YUNOMAE

--
Yoshihiro YUNOMAE
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: yoshihiro.yunomae.ez@xxxxxxxxxxx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/