Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

[George Cherian]

On 7/20/2013 12:12 AM, Sebastian Andrzej Siewior wrote:
> On 07/19/2013 08:33 PM, Sergei Shtylyov wrote:
> > Hello.
> Hello,
>
> > > usb: usb@47400000 {
> > >      compatible = "ti,am33xx-usb";
> > >      
> > >      usb0_phy: phy@47401300 {
> > >          compatible = "ti,am335x-usb-phy";
> > >      }
> > >      usb0: usb@47401000 {
> > >          musb0: usb@47401400 {
> > >              compatible = "mg,musbmhdrc";
> > >          }
> > >      }
> > >      usb1_phy: phy@47402300 {
> > >          compatible = "ti,am335x-usb-phy";
> > >      }
> > >      usb1: usb@47402000 {
> > >          musb1: usb@47402400 {
> > >              compatible = "mg,musbmhdrc";
> > >          }
> > >      }
> > > }
> > > And you want usb0_phy to be child of usb0? In the TRM they are all in
> > > the same block.
> >     Ah, the fact that PHYs didn't have the "reg" property got me muddled,
> > I didn't pay attention to the address part of the node names... BTW,
> > where is the "reg" prop?
> I skipped it for the general idea. I planned to repost is today but I
> messed up dsps and need to get it working first…
>
> > I see PHYs share the address space with
> > "omap-control-usb@44e10620" device -- what's the point with this?
> I decided to get rid of this. Both phys have 8 bytes (2 registers)
> which are exclusive for them.
> There is one register for the wakeup which is shared by both.
> I changed this to limit it only to the 8bytes per phy. I care about
> wakeup later - hopefully George will take care of this :)
But for wakeup how can we map it since its the same register. That is 
the main reason i took the
omap-control-usb route.

> > > Sebastian
> > WBR, Sergei
> Sebastian


--
-George

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/