Re: [PATCH] ALSA: SoC: Added jack detection kcontrol support

[Mark Brown]

On Fri, Jul 19, 2013 at 05:59:22PM -0700, Felipe F. Tonello wrote:
> From: "Felipe F. Tonello" <ftonello@xxxxxxxxxxxx>
> 
> It adds soc jack support for alsa kcontrol.
> 
> This support is necessary since the new kcontrol is used by user-space
> daemons, such as PulseAudio(>=2.0), to do jack detection.
> 
> Signed-off-by: Felipe F. Tonello <ftonello@xxxxxxxxxxxx>
> ---
>  include/sound/soc.h  |  1 +
>  sound/soc/Kconfig    |  1 +
>  sound/soc/soc-jack.c | 22 ++++++++++++++++++++++
>  3 files changed, 24 insertions(+)

No, this makes no sense at all as an ASoC specific feature - it should
be a standard feature of ALSA jacks.  The whole point of having ALSA
core infrastructure for jacks is to avoid having to go round doing make
work stuff like this.

The fact that the kcontrols were introduced as a HDA-specific feature at
all is of course a problem here...

Attachment: signature.asc
Description: Digital signature