Re: [PATCH 1/2] tools, perf: Add a precise event qualifier v2

From: Andi Kleen
Date: Tue Jul 23 2013 - 02:01:24 EST


On Tue, Jul 23, 2013 at 01:40:40AM -0400, Vince Weaver wrote:
> On Mon, 22 Jul 2013, Andi Kleen wrote:
>
> > From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> >
> > Add a precise qualifier, like cpu/event=0x3c,precise=1/
>
> So you're adding this to "events/" but not to "format/"?

Fair point, but note that precise_ip is a bitfield. Since there is no
way to express that currently the parser would need to special case it anyways.

So it could be just added as precise_ip: precise_ip in events/,
but I have some doubts that really helps anyone.

Or invent some new syntax to abstract the bitfields, but that also
would need changes.

> This will break various existing programs.

Like what?

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/