Re: [PATCH 10/21] earlycpio.c: Fix the confusing comment offind_cpio_data().

From: Tejun Heo
Date: Tue Jul 23 2013 - 16:02:42 EST


On Fri, Jul 19, 2013 at 03:59:23PM +0800, Tang Chen wrote:
> - * @offset: When a matching file is found, this is the offset to the
> - * beginning of the cpio. It can be used to iterate through
> - * the cpio to find all files inside of a directory path
> + * @offset: When a matching file is found, this is the offset from the
> + * beginning of the cpio to the beginning of the next file, not the
> + * matching file itself. It can be used to iterate through the cpio
> + * to find all files inside of a directory path

Nicely spotted. I think we can go further and rename it to @nextoff.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/