Re: [PATCH] video: xilinxfb: Fix compilation warning

[Michal Simek]

On 07/24/2013 08:00 AM, Jingoo Han wrote:
> On Wednesday, July 24, 2013 2:32 PM, Michal Simek wrote:
>>
>> regs_phys is phys_addr_t (u32 or u64).
>> Lets retype it to u64.
>>
>> Fixes compilation warning introduced by:
>> video: xilinxfb: Use drvdata->regs_phys instead of physaddr
>> (sha1: c88fafef0135e1e1c3e23c3e32ccbeeabc587f81)
> 
> CC'ed Stepan Moskovchenko
> 
> 
> phys_addr_t is defined as below:
> 
> #ifdef CONFIG_PHYS_ADDR_T_64BIT
> typedef u64 phys_addr_t;
> #else
> typedef u32 phys_addr_t;
> #endif
> 
> According to 'Documentation/printk-formats.txt',
> Physical addresses:
>        %pa     0x01234567 or 0x0123456789abcdef
>        For printing a phys_addr_t type (and its derivatives, such as
>        resource_size_t) which can vary based on build options, regardless of
>        the width of the CPU data path. Passed by reference.
> 
> Thus, '%pa' option looks proper, instead of casting (unsigned long long).
> 
> 		dev_dbg(dev, "regs: phys=%pa, virt=%p\n", drvdata->regs_phys,
> 					drvdata->regs);
> 

Ah. Wasn't aware about that.
Will retest.

Thanks,
Michal



-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform

Attachment: signature.asc
Description: OpenPGP digital signature